-
Notifications
You must be signed in to change notification settings - Fork 99
Allow to enable half and bfloat16 at the same time #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2bfb6ac
to
307e9e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first notes, I still have to finish the rest of the PR. However, I think these are already the most relevant comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. My comment on the ConvertibleTo
stuff can be ignored for this PR.
307e9e4
to
9318cec
Compare
9318cec
to
4f0036b
Compare
4f0036b
to
0c30ad2
Compare
0c30ad2
to
cc194b7
Compare
cc194b7
to
9278719
Compare
cf681ad
to
29df96b
Compare
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
7c3e451
to
83549e3
Compare
83549e3
to
22e11ec
Compare
Error: PR already merged! |
This PR allow to enable
bfloat16
andhalf
precision at the same time.Doing the operation between
bfloat16
andhalf
precision returnsfloat
type.It will revert the
gko::float16
alias changes in #1825 .float16
will behalf
precision again.Moreover, it adds the
next_precision_move<type, move>
to represent thenext_precision<next_precision<...
. same forprevious_precision_move
likely in another PR:
private:
and convert_to always call the templated functionrun<>
to acceptstype_list
and create a list for that