-
Notifications
You must be signed in to change notification settings - Fork 99
Add Bfloat16: alternative 16 bit floating point precision to half #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MarcelKoch
requested changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mostly smaller comments for this, rest looks good.
MarcelKoch
requested changes
Apr 17, 2025
MarcelKoch
approved these changes
Apr 22, 2025
…d implicit conversion
…loat16 (like rocm4.5/5.1.4)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1:ST:ready-to-merge
This PR is ready to merge.
mod:all
This touches all Ginkgo modules.
reg:build
This is related to the build system.
reg:documentation
This is related to documentation.
reg:helper-scripts
This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo.
reg:testing
This is related to testing.
type:factorization
This is related to the Factorizations
type:matrix-format
This is related to the Matrix formats
type:preconditioner
This is related to the preconditioners
type:reordering
This is related to the matrix(LinOp) reordering
type:solver
This is related to the solvers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bfloat16 precision but user can only select one of bfloat16 or half in ginkgo now.
There will be another pr to enable the possibility of having both at the same time, which should mostly contain the convert function/precision chain and some improvement to reduce the copy-paste stuff.
This PR currently use
gko::float16
for eitherhalf
orbfloat16
. I think float16 is confusing to people because it is the same term used by half.summary for different vendor bfloat16,
.reg
, which is unlike f16 for half precision__global__
). I need to add__device__
I guess it limits the searching space because we only provide the sqrt(bfloat16) in device.-
on rvalue will gives float before 2025.0.1 because it only accepted non-const reference before 2025.0.1