Add bucketsort kernels #1821
Open
Add bucketsort kernels #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
upsj
commented
Apr 3, 2025
| const auto sums = tmp.get_data(); | ||
| std::fill_n(sums, tmp_size, 0); | ||
| std::array<int64, num_buckets + 1> global_offsets{}; | ||
| #pragma omp parallel |
There was a problem hiding this comment.
Suggested change
| #pragma omp parallel | |
| #pragma omp parallel num_threads(num_threads) |
| } | ||
| } | ||
| std::copy_n(offsets.begin(), num_buckets, global_offsets.begin()); | ||
| std::exclusive_scan(global_offsets.begin(), global_offsets.end(), |
There was a problem hiding this comment.
This seems to be unsupported in one of the libstdc++ versions we are using (ROCm 4.5 job), but I think I would rather require a fully C++17 compliant compiler than work around this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from the symbolic Cholesky (but might also be useful for other things, e.g. parallel OpenMP COO sorting)