Skip to content

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Mar 26, 2025

This PR reuses the device_matrix_data sort_row_major by turning it to accept the pointer argument and add Transpose function to Coo under Transposable class.
I would also like to use this sort_row_major in pgm if the changes are acceptable. Otherwise, I will reuse the pgm::device_matrix_data in coo.

TODO:

  • reuse the sort_row_major in PGM or reuse it from PGM

@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Mar 26, 2025
@yhmtsai yhmtsai requested review from a team and greole March 26, 2025 14:10
@yhmtsai yhmtsai self-assigned this Mar 26, 2025
@ginkgo-bot ginkgo-bot added reg:testing This is related to testing. type:matrix-format This is related to the Matrix formats mod:all This touches all Ginkgo modules. labels Mar 26, 2025
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Apr 7, 2025
Copy link

sonarqubecloud bot commented Apr 8, 2025

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (cea1be7) to head (fc280ab).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
core/device_hooks/common_kernels.inc.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1816      +/-   ##
===========================================
+ Coverage    89.33%   89.57%   +0.24%     
===========================================
  Files          824      824              
  Lines        68799    68815      +16     
===========================================
+ Hits         61461    61643     +182     
+ Misses        7338     7172     -166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yhmtsai yhmtsai merged commit a83e557 into develop Apr 8, 2025
14 checks passed
@yhmtsai yhmtsai deleted the transposed_coo branch April 8, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. mod:all This touches all Ginkgo modules. reg:testing This is related to testing. type:matrix-format This is related to the Matrix formats

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants