Skip to content

Fix the mismatch type of VectorCache and index_map #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Fix the mismatch type of VectorCache and index_map #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/distributed/index_map.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ index_map<LocalIndexType, GlobalIndexType>::index_map(
}


#define GKO_DECLARE_INDEX_MAP(_ltype, _gtype) struct index_map<_ltype, _gtype>
#define GKO_DECLARE_INDEX_MAP(_ltype, _gtype) class index_map<_ltype, _gtype>

GKO_INSTANTIATE_FOR_EACH_LOCAL_GLOBAL_INDEX_TYPE(GKO_DECLARE_INDEX_MAP);

Expand Down
3 changes: 2 additions & 1 deletion include/ginkgo/core/distributed/index_map.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ enum class index_space {
* \tparam GlobalIndexType type for global indices
*/
template <typename LocalIndexType, typename GlobalIndexType = int64>
struct index_map {
class index_map {
public:
using partition_type = Partition<LocalIndexType, GlobalIndexType>;

/**
Expand Down
5 changes: 3 additions & 2 deletions include/ginkgo/core/distributed/vector_cache.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors
// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
//
// SPDX-License-Identifier: BSD-3-Clause

Expand Down Expand Up @@ -33,7 +33,8 @@ namespace detail {
* not be copied when the outer object gets copied.
*/
template <typename ValueType>
struct VectorCache {
class VectorCache {
public:
VectorCache() = default;
~VectorCache() = default;
VectorCache(const VectorCache&) {}
Expand Down
2 changes: 1 addition & 1 deletion include/ginkgo/core/matrix/dense.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors
// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
//
// SPDX-License-Identifier: BSD-3-Clause

Expand Down