Fix the mismatch type of VectorCache and index_map #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
1:ST:ready-for-review
ginkgo-bot
added
mod:core
MarcelKoch
approved these changes
Mar 6, 2025
yhmtsai
force-pushed
the
fix_mismatch_type
branch
from
e54e550 to
3cbc472
Compare
yhmtsai
added
1:ST:ready-to-merge
MarcelKoch
approved these changes
Mar 6, 2025
yhmtsai
force-pushed
the
fix_mismatch_type
branch
from
3cbc472 to
02a5695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for @greole report, we mismatch class and struct of
VectorCacheandindex_map.This PR fixes the mismatch part.