Skip to content

chore(launchpad): Include appid and appname in update endpoint #95583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

chore(launchpad): Include appid and appname in update endpoint #95583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/sentry/preprod/api/endpoints/project_preprod_artifact_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ def validate_preprod_artifact_update_schema(request_body: bytes) -> tuple[dict,
"build_number": {"type": "integer"},
"error_code": {"type": "integer", "minimum": 0, "maximum": 3},
"error_message": {"type": "string"},
"app_id": {"type": "string", "maxLength": 255},
"app_name": {"type": "string", "maxLength": 255},
"apple_app_info": {
"type": "object",
"properties": {
Expand All @@ -51,6 +53,8 @@ def validate_preprod_artifact_update_schema(request_body: bytes) -> tuple[dict,
"error_message": "The error_message field must be a string.",
"build_version": "The build_version field must be a string with a maximum length of 255 characters.",
"build_number": "The build_number field must be an integer.",
"app_id": "The app_id field must be a string with a maximum length of 255 characters.",
"app_name": "The app_name field must be a string with a maximum length of 255 characters.",
"apple_app_info": "The apple_app_info field must be an object.",
"apple_app_info.is_simulator": "The is_simulator field must be a boolean.",
"apple_app_info.codesigning_type": "The codesigning_type field must be a string.",
Expand Down Expand Up @@ -158,6 +162,14 @@ def put(self, request: Request, project, artifact_id) -> Response:
preprod_artifact.build_number = data["build_number"]
updated_fields.append("build_number")

if "app_id" in data:
preprod_artifact.app_id = data["app_id"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "app_id" the right name? I see bundle_id in AppleAppInfo but not sure what the type of "data" is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synced offline , going with app_id as the platform agnostic term

updated_fields.append("app_id")

if "app_name" in data:
preprod_artifact.app_name = data["app_name"]
updated_fields.append("app_name")

if "apple_app_info" in data:
apple_info = data["apple_app_info"]
parsed_apple_info = {}
Expand Down
Loading