chore(launchpad): Include appid and appname in update endpoint #95583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_19bf7f71-e2ee-49eb-ad47-722398c7f90d). |
noahsmartin
reviewed
Jul 15, 2025
| @@ -158,6 +162,14 @@ def put(self, request: Request, project, artifact_id) -> Response: | |||
| preprod_artifact.build_number = data["build_number"] | |||
| updated_fields.append("build_number") | |||
|
|
|||
| if "app_id" in data: | |||
| preprod_artifact.app_id = data["app_id"] | |||
There was a problem hiding this comment.
is "app_id" the right name? I see bundle_id in AppleAppInfo but not sure what the type of "data" is
There was a problem hiding this comment.
synced offline , going with app_id as the platform agnostic term
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95583 +/- ##
==========================================
+ Coverage 82.91% 87.71% +4.80%
==========================================
Files 10553 10553
Lines 608074 608080 +6
Branches 23833 23833
==========================================
+ Hits 504171 533387 +29216
+ Misses 103607 74397 -29210
Partials 296 296 |
noahsmartin
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup for #95383