Skip to content

ref(gsAdmin): Rewrite <ForkCustomerAction> as a functional component #95399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ref(gsAdmin): Rewrite <ForkCustomerAction> as a functional component #95399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25c8e3a
ref(gsAdmin): Rewrite `<ForkCustomerAction>` as a functional component
ryan953 Jul 12, 2025
63a1c4f
account for unstable setConfirmCallback
ryan953 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 60 additions & 59 deletions static/gsAdmin/components/forkCustomer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import {Component, Fragment} from 'react';
import {Fragment, useEffect, useRef, useState} from 'react';

import {Client} from 'sentry/api';
import SelectField from 'sentry/components/forms/fields/selectField';
import type {Organization} from 'sentry/types/organization';
import {browserHistory} from 'sentry/utils/browserHistory';
import {useMutation} from 'sentry/utils/queryClient';
import {
getRegionChoices,
getRegionDataFromOrganization,
getRegions,
} from 'sentry/utils/regions';
import type RequestError from 'sentry/utils/requestError/requestError';
import useApi from 'sentry/utils/useApi';
import {useNavigate} from 'sentry/utils/useNavigate';

import type {
AdminConfirmParams,
Expand All @@ -19,69 +21,68 @@ type Props = AdminConfirmRenderProps & {
organization: Organization;
};

type State = {
regionUrl: string;
};

/**
* Rendered as part of a openAdminConfirmModal call
*/
class ForkCustomerAction extends Component<Props> {
state: State = {
regionUrl: '',
};
export default function ForkCustomerAction({
organization,
onConfirm,
setConfirmCallback,
}: Props) {
// TODO: We should make sure that `setConfirmCallback` is a stable function
// before passing it in here. But because it's not memoized right now, we
// need to store it in a ref between renders.
const onConfirmRef = useRef(setConfirmCallback);

Comment on lines +32 to +35
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big problem

componentDidMount() {
this.props.setConfirmCallback(this.handleConfirm);
}
const [regionUrl, setRegionUrl] = useState('');
const api = useApi({persistInFlight: true});
const navigate = useNavigate();

handleConfirm = async (params: AdminConfirmParams) => {
const api = new Client({headers: {Accept: 'application/json; charset=utf-8'}});
const {organization} = this.props;
const {regionUrl} = this.state;
const regions = getRegions();
const region = regions.find(r => r.url === regionUrl);

try {
const response = await api.requestPromise(
`/organizations/${organization.slug}/fork/`,
{
method: 'POST',
host: region?.url,
}
);
const {mutate} = useMutation<any, RequestError, AdminConfirmParams>({
mutationFn: () => {
const regions = getRegions();
const region = regions.find(r => r.url === regionUrl);

browserHistory.push(`/_admin/relocations/${region?.name}/${response.uuid}/`);
this.props.onConfirm?.({regionUrl, ...params});
} catch (error) {
return api.requestPromise(`/organizations/${organization.slug}/fork/`, {
method: 'POST',
host: region?.url,
});
},
onSuccess: (response, params) => {
const regions = getRegions();
const region = regions.find(r => r.url === regionUrl);
navigate(`/_admin/relocations/${region?.name}/${response.uuid}/`);
onConfirm?.({regionUrl, ...params});
},
onError: (error: RequestError, _params) => {
if (error.responseJSON) {
this.props.onConfirm?.({error});
onConfirm?.({error});
}
}
};
},
});

render() {
const {organization} = this.props;
const currentRegionData = getRegionDataFromOrganization(organization);
const regionChoices = getRegionChoices(currentRegionData ? [currentRegionData] : []);
return (
<Fragment>
<SelectField
name="regionUrl"
label={'Duplicate into Region'}
help={
"Choose which region to duplicate this organization's low volume metadata into. This will kick off a SAAS->SAAS relocation job, but the source organization will not be affected."
}
choices={regionChoices}
inline={false}
stacked
required
value={this.state.regionUrl}
onChange={(val: any) => this.setState({regionUrl: val})}
/>
</Fragment>
);
}
}
useEffect(() => {
onConfirmRef.current(mutate);
}, [mutate]);

const currentRegionData = getRegionDataFromOrganization(organization);
const regionChoices = getRegionChoices(currentRegionData ? [currentRegionData] : []);

export default ForkCustomerAction;
return (
<Fragment>
<SelectField
name="regionUrl"
label={'Duplicate into Region'}
help={
"Choose which region to duplicate this organization's low volume metadata into. This will kick off a SAAS->SAAS relocation job, but the source organization will not be affected."
}
choices={regionChoices}
inline={false}
stacked
required
value={regionUrl}
onChange={setRegionUrl}
/>
</Fragment>
);
}
Loading