Skip to content

ref(gsAdmin): Rewrite <ForkCustomerAction> as a functional component #95399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ref(gsAdmin): Rewrite <ForkCustomerAction> as a functional component #95399

wants to merge 1 commit into from
+56 −60

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jul 12, 2025 •
edited
Loading

Cursor helped a lot here

Related to https://github.com/getsentry/frontend-tsc/issues/42

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 12, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10801 1 10800 9
View the top 1 failed test(s) by shortest run time 
Customer Details fork customer forks a customer
Stack Traces | 1.46s run time 
Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
    at getRootForUpdatedFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:3860:11)
    at enqueueConcurrentHookUpdate (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:3820:14)
    at dispatchSetStateInternal (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:6966:18)
    at dispatchSetState (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:6927:7)
    at .../core/input/inputGroup.tsx:167:23
    at Object.react-stack-bottom-frame (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:23949:20)
    at runWithFiberInDEV (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:1522:13)
    at commitHookEffectListMount (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:11905:29)
    at commitHookLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:11857:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12613:13)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12616:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12727:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12611:11)
    at recursivelyTraverseLayoutEffects (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:13590:11)
    at commitLayoutEffectOnFiber (.../sentry/node_modules/.pnpm/react-dom@19.1.0_react@19.1..../react-dom/cjs/react-dom-client.development.js:12791:11)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryan953