Skip to content

fix(analytics): missing 'data' attribute exclusion #95219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
+30 −1
Merged

fix(analytics): missing 'data' attribute exclusion #95219

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54f0bb8
fix(analytics): missing 'data' attribute exclusion
constantinius Jul 10, 2025
bd4eaf1
test(analytics): add test for new-style events .from_instance()
constantinius Jul 10, 2025
6cabd5a
fix(analytics): fixing type check
constantinius Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/sentry/analytics/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,13 @@ def from_instance(cls, instance: Any, **kwargs: Any) -> Self:
**{
f.name: kwargs.get(f.name, getattr(instance, f.name, None))
for f in fields(cls)
if f.name not in ("type", "uuid_", "datetime_")
if f.name
not in (
"type",
"uuid_",
"datetime_",
"data", # TODO: remove this data field once migrated
)
Comment on lines +116 to +122
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what this does - could we have a test to make sure this has the intended effect?

}
)

Expand Down
Loading