fix(analytics): missing 'data' attribute exclusion #95219
Merged
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
shellmayr
reviewed
Jul 10, 2025
Comment on lines
+116
to
+122
| if f.name | ||
| not in ( | ||
| "type", | ||
| "uuid_", | ||
| "datetime_", | ||
| "data", # TODO: remove this data field once migrated | ||
| ) |
There was a problem hiding this comment.
Not entirely sure what this does - could we have a test to make sure this has the intended effect?
shellmayr
approved these changes
Jul 10, 2025
constantinius
deleted the
constantinius/fix/analytics/event-missing-attribute-exclusion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dataattribute is just there for backwards compatibility, and needs special treatment