Skip to content

ref(remix-wizard): Fix creation sentry example when no routes folder #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2024
Merged

ref(remix-wizard): Fix creation sentry example when no routes folder #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9b431e
ref(remix-wizard): Fix creation sentry example when no routes folder …
priscilawebdev Sep 30, 2024
381f068
update changelog
priscilawebdev Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- Fix creation sentry example when no routes folder ([#680](https://github.com/getsentry/sentry-wizard/pull/680))

## 3.32.0

- feat: Add `--saas` CLI arg to skip self-hosted or SaaS selection step (#678)
Expand Down
6 changes: 6 additions & 0 deletions src/remix/sdk-example.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ export async function createExamplePage(options: {
url: string;
isTS: boolean;
}) {
const routesPath = 'app/routes';

if (!fs.existsSync(routesPath)) {
fs.mkdirSync(routesPath);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may fail, when there is no /app folder. We probably want to do fs.mkdirSync(routesPath, { recursive: true }).

Copy link
Member Author

@priscilawebdev priscilawebdev Oct 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great feedback @lforst . I updated the code in the PR #681

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it fails to create the file if the app folder doesn't exist. It's part of the default Remix setup, so it's unlikely to be missing, but adding recursive: true was a good idea

}

const exampleRoutePath = `app/routes/sentry-example-page.${
options.isTS ? 'ts' : 'js'
}x`;
Expand Down
Loading