ref(remix-wizard): Fix creation sentry example when no routes folder #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
deleted the
priscila/fix/remix/creation-sentry-example-page
branch
lforst
reviewed
Oct 1, 2024
| const routesPath = 'app/routes'; | ||
|
|
||
| if (!fs.existsSync(routesPath)) { | ||
| fs.mkdirSync(routesPath); |
There was a problem hiding this comment.
I think this may fail, when there is no /app folder. We probably want to do fs.mkdirSync(routesPath, { recursive: true }).
There was a problem hiding this comment.
Yes, it fails to create the file if the app folder doesn't exist. It's part of the default Remix setup, so it's unlikely to be missing, but adding recursive: true was a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a Remix project doesn't yet have a routes folder, as was the case when I followed only the initial steps of this tutorial, running the Sentry wizard and answering 'yes' to create a Sentry example fails to generate the example, and no feedback is provided.
Solution
Update the code to check whether the routes folder exists. If it doesn’t, create the folder to allow the Sentry example to be successfully generated.
Note
Users will still need to complete this step to fully view the Sentry example. However, since the route will be created, users will at least see some feedback in the project - the new file.
closes getsentry/sentry#78331