Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ @interface SentryWatchdogTerminationBreadcrumbProcessor ()
@implementation SentryWatchdogTerminationBreadcrumbProcessor

- (instancetype)initWithMaxBreadcrumbs:(NSInteger)maxBreadcrumbs
fileManager:(SentryFileManager *)fileManager
fileManager:(SentryFileManager *_Nullable)fileManager
{
if (self = [super init]) {
self.fileManager = fileManager;
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryDefaultAppStateManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ @interface SentryDefaultAppStateManager ()

@implementation SentryDefaultAppStateManager

- (instancetype)initWithOptions:(SentryOptions *)options
- (instancetype)initWithOptions:(SentryOptions *_Nullable)options
crashWrapper:(SentryCrashWrapper *)crashWrapper
fileManager:(SentryFileManager *)fileManager
fileManager:(SentryFileManager *_Nullable)fileManager
dispatchQueueWrapper:(SentryDispatchQueueWrapper *)dispatchQueueWrapper
notificationCenterWrapper:(id<SentryNSNotificationCenterWrapper>)notificationCenterWrapper
{
Expand Down
3 changes: 2 additions & 1 deletion Sources/Sentry/SentryDependencyContainer.m
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ - (SentryMXManager *)metricKitManager SENTRY_THREAD_SANITIZER_DOUBLE_CHECKED_LOC

#endif // SENTRY_HAS_METRIC_KIT

- (SentryScopePersistentStore *)scopePersistentStore SENTRY_THREAD_SANITIZER_DOUBLE_CHECKED_LOCK
- (SentryScopePersistentStore *_Nullable)
scopePersistentStore SENTRY_THREAD_SANITIZER_DOUBLE_CHECKED_LOCK
{
SENTRY_LAZY_INIT(_scopePersistentStore,
[[SentryScopePersistentStore alloc] initWithFileManager:self.fileManager]);
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryFileManagerHelper.m
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ @interface SentryFileManagerHelper ()

@implementation SentryFileManagerHelper

- (nullable instancetype)initWithOptions:(SentryOptions *)options error:(NSError **)error
- (nullable instancetype)initWithOptions:(SentryOptions *_Nullable)options error:(NSError **)error
{
if (self = [super init]) {
[self createPathsWithOptions:options];
Expand All @@ -128,7 +128,7 @@ - (nullable instancetype)initWithOptions:(SentryOptions *)options error:(NSError
return self;
}

- (void)createPathsWithOptions:(SentryOptions *)options
- (void)createPathsWithOptions:(SentryOptions *_Nullable)options
{
NSString *cachePath = options.cacheDirectoryPath;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ SENTRY_NO_INIT
@property (nonatomic, strong, readonly) SentryThreadInspector *threadInspector;
@property (nonatomic, strong, readonly) SentryFileIOTracker *fileIOTracker;
@property (nonatomic, strong) SentryCrashSwift *crashReporter;
@property (nonatomic, strong) SentryScopePersistentStore *scopePersistentStore;
@property (nonatomic, strong, nullable) SentryScopePersistentStore *scopePersistentStore;
@property (nonatomic, strong) SentryDebugImageProvider *debugImageProvider;

- (id<SentryANRTracker>)getANRTracker:(NSTimeInterval)timeout;
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/include/SentryDefaultAppStateManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ SENTRY_NO_INIT

@property (nonatomic, readonly) NSInteger startCount;

- (instancetype)initWithOptions:(SentryOptions *)options
- (instancetype)initWithOptions:(SentryOptions *_Nullable)options
crashWrapper:(SentryCrashWrapper *)crashWrapper
fileManager:(SentryFileManager *)fileManager
fileManager:(SentryFileManager *_Nullable)fileManager
dispatchQueueWrapper:(SentryDispatchQueueWrapper *)dispatchQueueWrapper
notificationCenterWrapper:(id<SentryNSNotificationCenterWrapper>)notificationCenterWrapper;

Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/include/SentryFileManagerHelper.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ SENTRY_NO_INIT

@property (nonatomic, copy, nullable) void (^handleEnvelopesLimit)(void);

- (nullable instancetype)initWithOptions:(SentryOptions *)options
- (nullable instancetype)initWithOptions:(SentryOptions *_Nullable)options
error:(NSError **)error NS_DESIGNATED_INITIALIZER;

#pragma mark - Envelope
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ NS_ASSUME_NONNULL_BEGIN
@interface SentryWatchdogTerminationBreadcrumbProcessor : NSObject

- (instancetype)initWithMaxBreadcrumbs:(NSInteger)maxBreadcrumbs
fileManager:(SentryFileManager *)fileManager;
fileManager:(SentryFileManager *_Nullable)fileManager;

- (void)addSerializedBreadcrumb:(NSDictionary *)crumb;

Expand Down
2 changes: 1 addition & 1 deletion Sources/Swift/Helper/SentryFileManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
helper.previousBreadcrumbsFilePathTwo
}

@objc public init(options: Options, dateProvider: SentryCurrentDateProvider, dispatchQueueWrapper: SentryDispatchQueueWrapper) throws {
@objc public init(options: Options?, dateProvider: SentryCurrentDateProvider, dispatchQueueWrapper: SentryDispatchQueueWrapper) throws {
dispatchQueue = dispatchQueueWrapper
self.dateProvider = dateProvider
helper = try SentryFileManagerHelper(options: options)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import Foundation
@_spi(Private) public class SentryWatchdogTerminationAttributesProcessor: NSObject {

private let dispatchQueueWrapper: SentryDispatchQueueWrapper
private let scopePersistentStore: SentryScopePersistentStore
private let scopePersistentStore: SentryScopePersistentStore?

public init(
withDispatchQueueWrapper dispatchQueueWrapper: SentryDispatchQueueWrapper,
scopePersistentStore: SentryScopePersistentStore
scopePersistentStore: SentryScopePersistentStore?
) {
self.dispatchQueueWrapper = dispatchQueueWrapper
self.scopePersistentStore = scopePersistentStore
Expand All @@ -21,48 +21,48 @@ import Foundation

public func clear() {
SentrySDKLog.debug("Deleting all stored data in in persistent store")
scopePersistentStore.deleteAllCurrentState()
scopePersistentStore?.deleteAllCurrentState()
}

public func setContext(_ context: [String: [String: Any]]?) {
setData(data: context, field: .context) { [weak self] data in
self?.scopePersistentStore.writeContextToDisk(context: data)
self?.scopePersistentStore?.writeContextToDisk(context: data)
}
}

public func setUser(_ user: User?) {
setData(data: user, field: .user) { [weak self] data in
self?.scopePersistentStore.writeUserToDisk(user: data)
self?.scopePersistentStore?.writeUserToDisk(user: data)
}
}

public func setDist(_ dist: String?) {
setData(data: dist, field: .dist) { [weak self] data in
self?.scopePersistentStore.writeDistToDisk(dist: data)
self?.scopePersistentStore?.writeDistToDisk(dist: data)
}
}

public func setEnvironment(_ environment: String?) {
setData(data: environment, field: .environment) { [weak self] data in
self?.scopePersistentStore.writeEnvironmentToDisk(environment: data)
self?.scopePersistentStore?.writeEnvironmentToDisk(environment: data)
}
}

public func setTags(_ tags: [String: String]?) {
setData(data: tags, field: .tags) { [weak self] data in
self?.scopePersistentStore.writeTagsToDisk(tags: data)
self?.scopePersistentStore?.writeTagsToDisk(tags: data)
}
}

public func setExtras(_ extras: [String: Any]?) {
setData(data: extras, field: .extras) { [weak self] data in
self?.scopePersistentStore.writeExtrasToDisk(extras: data)
self?.scopePersistentStore?.writeExtrasToDisk(extras: data)
}
}

public func setFingerprint(_ fingerprint: [String]?) {
setData(data: fingerprint, field: .fingerprint) { [weak self] data in
self?.scopePersistentStore.writeFingerprintToDisk(fingerprint: data)
self?.scopePersistentStore?.writeFingerprintToDisk(fingerprint: data)
}
}

Expand All @@ -76,7 +76,7 @@ import Foundation
}
guard let data = data else {
SentrySDKLog.debug("Data for \(field.name) is nil, deleting active file.")
strongSelf.scopePersistentStore.deleteCurrentFieldOnDisk(field: field)
strongSelf.scopePersistentStore?.deleteCurrentFieldOnDisk(field: field)
return
}
save(data)
Expand Down
Loading