-
-
Notifications
You must be signed in to change notification settings - Fork 366
fix: Incorrect nullability in some dependencies #6448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6448 +/- ##
=============================================
+ Coverage 86.706% 86.972% +0.266%
=============================================
Files 449 449
Lines 37636 37637 +1
Branches 17449 17459 +10
=============================================
+ Hits 32633 32734 +101
+ Misses 4958 4860 -98
+ Partials 45 43 -2
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0e9c5ae | 1226.10 ms | 1254.14 ms | 28.04 ms |
fc05805 | 1220.63 ms | 1252.16 ms | 31.54 ms |
d157d83 | 1228.02 ms | 1252.47 ms | 24.45 ms |
1fecbb8 | 1242.78 ms | 1265.40 ms | 22.62 ms |
d8b2303 | 1231.53 ms | 1249.89 ms | 18.35 ms |
c6c1cb7 | 1235.71 ms | 1263.80 ms | 28.08 ms |
3b373bb | 1218.19 ms | 1250.57 ms | 32.38 ms |
397b9c9 | 1230.23 ms | 1249.29 ms | 19.06 ms |
b714cb9 | 1224.71 ms | 1238.04 ms | 13.33 ms |
c30e401 | 1218.71 ms | 1243.73 ms | 25.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0e9c5ae | 23.75 KiB | 969.29 KiB | 945.54 KiB |
fc05805 | 23.75 KiB | 908.02 KiB | 884.27 KiB |
d157d83 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
1fecbb8 | 23.75 KiB | 969.28 KiB | 945.53 KiB |
d8b2303 | 23.75 KiB | 908.02 KiB | 884.27 KiB |
c6c1cb7 | 23.75 KiB | 928.15 KiB | 904.40 KiB |
3b373bb | 23.75 KiB | 947.72 KiB | 923.97 KiB |
397b9c9 | 23.75 KiB | 959.44 KiB | 935.70 KiB |
b714cb9 | 23.75 KiB | 858.69 KiB | 834.93 KiB |
c30e401 | 23.74 KiB | 971.70 KiB | 947.96 KiB |
7db027d
to
f3d25fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some of the nullability annotations were being misused here, in Swift they will have to be correct so I just pulled it out into a separate PR
#skip-changelog
Closes #6449