Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 17, 2025

Some of the nullability annotations were being misused here, in Swift they will have to be correct so I just pulled it out into a separate PR

#skip-changelog

Closes #6449

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.972%. Comparing base (dad3d69) to head (f3d25fd).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6448       +/-   ##
=============================================
+ Coverage   86.706%   86.972%   +0.266%     
=============================================
  Files          449       449               
  Lines        37636     37637        +1     
  Branches     17449     17459       +10     
=============================================
+ Hits         32633     32734      +101     
+ Misses        4958      4860       -98     
+ Partials        45        43        -2     
Files with missing lines Coverage Δ
...ors/SentryWatchdogTerminationBreadcrumbProcessor.m 98.571% <ø> (ø)
Sources/Sentry/SentryDefaultAppStateManager.m 100.000% <ø> (ø)
Sources/Sentry/SentryDependencyContainer.m 90.254% <ø> (ø)
Sources/Sentry/SentryFileManagerHelper.m 90.715% <ø> (ø)
Sources/Swift/Helper/SentryFileManager.swift 95.815% <100.000%> (ø)
...SentryWatchdogTerminationAttributesProcessor.swift 100.000% <100.000%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad3d69...f3d25fd. Read the comment docs.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Oct 17, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.00 ms 1252.18 ms 26.18 ms
Size 23.75 KiB 1015.08 KiB 991.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0e9c5ae 1226.10 ms 1254.14 ms 28.04 ms
fc05805 1220.63 ms 1252.16 ms 31.54 ms
d157d83 1228.02 ms 1252.47 ms 24.45 ms
1fecbb8 1242.78 ms 1265.40 ms 22.62 ms
d8b2303 1231.53 ms 1249.89 ms 18.35 ms
c6c1cb7 1235.71 ms 1263.80 ms 28.08 ms
3b373bb 1218.19 ms 1250.57 ms 32.38 ms
397b9c9 1230.23 ms 1249.29 ms 19.06 ms
b714cb9 1224.71 ms 1238.04 ms 13.33 ms
c30e401 1218.71 ms 1243.73 ms 25.02 ms

App size

Revision Plain With Sentry Diff
0e9c5ae 23.75 KiB 969.29 KiB 945.54 KiB
fc05805 23.75 KiB 908.02 KiB 884.27 KiB
d157d83 23.75 KiB 928.85 KiB 905.10 KiB
1fecbb8 23.75 KiB 969.28 KiB 945.53 KiB
d8b2303 23.75 KiB 908.02 KiB 884.27 KiB
c6c1cb7 23.75 KiB 928.15 KiB 904.40 KiB
3b373bb 23.75 KiB 947.72 KiB 923.97 KiB
397b9c9 23.75 KiB 959.44 KiB 935.70 KiB
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB
c30e401 23.74 KiB 971.70 KiB 947.96 KiB

Previous results on branch: fixDependencyNullability

Startup times

Revision Plain With Sentry Diff
fbf30aa 1232.52 ms 1263.89 ms 31.37 ms

App size

Revision Plain With Sentry Diff
fbf30aa 23.75 KiB 1015.06 KiB 991.31 KiB

@noahsmartin noahsmartin force-pushed the fixDependencyNullability branch from 7db027d to f3d25fd Compare October 17, 2025 15:34
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin merged commit aa643c5 into main Oct 17, 2025
189 of 191 checks passed
@noahsmartin noahsmartin deleted the fixDependencyNullability branch October 17, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Incorrect nullability in some dependencies

2 participants