Skip to content

fix: Build error on Xcode 14.2 #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged

fix: Build error on Xcode 14.2 #5917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4506bdb
fix: Build error on Xcode 14.2
itaybre Aug 13, 2025
669f02c
Add changelog
itaybre Aug 13, 2025
dba4ee8
Refactor SentryFeedback serialization to have 2 declarations dependin…
itaybre Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
- Add a new prebuilt framework with ARM64e for WithoutUIKitOrAppKit (#5897)
- Add source context and vars fields to SentryFrame (#5853)

### Fixes

- Fixed a build error in `SentryFeedback.swift` when building with cocoapods on Xcode 14.2 (#5917)

## 8.54.1-alpha.1

- No documented changes.
Expand Down
11 changes: 9 additions & 2 deletions Sources/Swift/Integrations/UserFeedback/SentryFeedback.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,16 @@ extension SentryFeedback: SentrySerializable { }

extension SentryFeedback {
#if SDK_V9
@_spi(Private)
#endif
@_spi(Private) public func serialize() -> [String: Any] {
return internalSerialize()
}
#else
public func serialize() -> [String: Any] {
return internalSerialize()
}
#endif

private func internalSerialize() -> [String: Any] {
let numberOfOptionalItems = (name == nil ? 0 : 1) + (email == nil ? 0 : 1) + (associatedEventId == nil ? 0 : 1)
var dict = [String: Any](minimumCapacity: 2 + numberOfOptionalItems)
dict["message"] = message
Expand Down
Loading