Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Aug 13, 2025

Fixes a build error on RN SDK with Xcode 14.2: https://github.com/getsentry/sentry-react-native/actions/runs/16932149646/job/47988490015?pr=5038

Old swift version might have not liked the @spi inside the a precompiler flag block

Seems to only happen when building from source or with CocoaPods

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.661%. Comparing base (32584c4) to head (dba4ee8).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5917       +/-   ##
=============================================
- Coverage   86.687%   86.661%   -0.027%     
=============================================
  Files          423       423               
  Lines        36583     36586        +3     
  Branches     17330     17329        -1     
=============================================
- Hits         31713     31706        -7     
- Misses        4826      4834        +8     
- Partials        44        46        +2     
Files with missing lines Coverage Δ
...ift/Integrations/UserFeedback/SentryFeedback.swift 74.137% <100.000%> (+1.410%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32584c4...dba4ee8. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 13, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.80 ms 1247.35 ms 14.55 ms
Size 23.75 KiB 920.52 KiB 896.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2a36c3f 1227.27 ms 1246.89 ms 19.63 ms
42a95d5 1206.00 ms 1224.26 ms 18.26 ms
9e0030e 1222.78 ms 1242.23 ms 19.45 ms
aadbffe 1228.73 ms 1251.59 ms 22.86 ms
e18d392 1228.69 ms 1244.43 ms 15.73 ms
3c86ff3 1227.82 ms 1239.73 ms 11.91 ms
c3fece5 1240.65 ms 1260.75 ms 20.10 ms
fd5961e 1210.59 ms 1235.57 ms 24.98 ms
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
bbe6658 1221.00 ms 1248.51 ms 27.51 ms

App size

Revision Plain With Sentry Diff
2a36c3f 23.75 KiB 874.45 KiB 850.71 KiB
42a95d5 23.75 KiB 906.08 KiB 882.33 KiB
9e0030e 23.75 KiB 893.72 KiB 869.97 KiB
aadbffe 23.75 KiB 912.77 KiB 889.02 KiB
e18d392 23.75 KiB 866.68 KiB 842.93 KiB
3c86ff3 23.75 KiB 919.69 KiB 895.94 KiB
c3fece5 23.75 KiB 874.17 KiB 850.42 KiB
fd5961e 23.74 KiB 874.07 KiB 850.32 KiB
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
bbe6658 23.75 KiB 908.02 KiB 884.27 KiB

Previous results on branch: itaybre/fix_build_on_xcode14.2

Startup times

Revision Plain With Sentry Diff
23467c0 1215.55 ms 1245.53 ms 29.98 ms

App size

Revision Plain With Sentry Diff
23467c0 23.75 KiB 920.67 KiB 896.92 KiB

@itaybre itaybre merged commit 45482a6 into main Aug 13, 2025
193 checks passed
@itaybre itaybre deleted the itaybre/fix_build_on_xcode14.2 branch August 13, 2025 17:19
@abrahem79
Copy link

كودكوف تقرير

✅ يتم تغطية جميع الخطوط المعدلة والقابلة للتغطية بالاختبارات. ✅ تبلغ نسبة تغطية المشروع 86.661٪. مقارنة القاعدة () بالرأس (). ⚠️ التقرير هو 2 يلتزم خلف الرأس على الرئيسي. ✅ نجحت جميع الاختبارات. لم يتم العثور على اختبارات فاشلة.

تفاصيل إضافية والملفات المتأثرة

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants