chore: upgrade to tailwindv4 #64
Conversation
✅ Deploy Preview for hoppdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
thanks for the upgrade to v4 @mumair5393 🙏 Could you merge or rebase to current main? |
mumair5393
force-pushed
the
feature/upgrade-to-tailwindv4
branch
from
7594600 to
4465081
Compare
There was a problem hiding this comment.
Thanks for the PR mate, some feedback points:
- Sidebar width is no the same as before
-
Many changes are just semicolons, could you maybe add the https://prettier.io/docs/options#semicolons option in our prettier config, and re-format so we can use this. Turns out if we don't our IDE does whatever it wants. Ideally those should not be changes of this PR, its pure noise 🥲
-
I guess some shadcn components were "re-added" but this means any custom override we have created was removed like in the button component. We need to make sure that we keep custom overrides that are used.
-
App version in context menu has different styling:
- End call button styles are broken, probably from the previous points
- Text input seems a bit off
- Text colors seem off
| "hover:bg-slate-100 hover:text-slate-900 dark:hover:bg-slate-800 dark:hover:text-slate-50", | ||
| ghost: "hover:bg-slate-100 hover:text-slate-900 dark:hover:bg-slate-800 dark:hover:text-slate-50", | ||
| link: "text-slate-900 underline-offset-4 hover:underline dark:text-slate-50", | ||
| hidden: "hidden", |
There was a problem hiding this comment.
Any reason those were removed? They are actively used example:
<Button
variant={
needsUpdate ?
updateInProgress ?
"loading"
: "default"
: "hidden"
}
... />
| sm: "h-8 rounded-md px-3 text-xs", | ||
| lg: "h-10 rounded-md px-8", | ||
| icon: "h-9 w-9", | ||
| "icon-sm": "h-7 w-7", |
| extends React.ButtonHTMLAttributes<HTMLButtonElement>, | ||
| VariantProps<typeof buttonVariants> { | ||
| asChild?: boolean; | ||
| isLoading?: boolean; // Add isLoading prop |
| className={cn(buttonVariants({ variant, size, className }))} | ||
| ref={ref} | ||
| {...props} | ||
| > |
mumair5393
force-pushed
the
feature/upgrade-to-tailwindv4
branch
from
841d054 to
2913690
Compare
There was a problem hiding this comment.
- Shadow in web-app is off, I suspect the migration might now right properly in Web App? Or was it a rebase issue?
I pushed a minor commit for this one.
- Input focused state is diff
I suspect this is the change:
https://github.com/gethopp/hopp/pull/64/files#diff-fe29196ef6c52b4d2f09656b580ca6c34b874b21d2471b03eb3d9c0b71e0b113R76-R91
- Text color is diff inside Invite tab
I guess its related to this one:
https://corner.buka.sh/understanding-text-color-conflicts-in-tailwind-css-v4/
2 participants
Closes #11
This PR includes:
Shall I also remove forward ref as proposed in here?