Skip to content
This repository was archived by the owner on Nov 6, 2022. It is now read-only.

Update versions in package.json, use @wordpress/scripts for build process #492

Merged
merged 17 commits into from
Jan 13, 2020
Merged

Update versions in package.json, use @wordpress/scripts for build process #492

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0c57b81
Update npm packages to the latest versions
kienstra Dec 17, 2019
7b643f4
Update some more npm packages and webpack.config.js
kienstra Dec 18, 2019
e6cbebe
Use the @wordpress/scripts package to build JS
kienstra Dec 18, 2019
057e2b3
Add trailing commas to object values, from doing npm run lint:js:fix
kienstra Dec 18, 2019
66e1649
Commit package-lock.json, exclude map files from build in gulpfile.js
kienstra Dec 18, 2019
4005f48
Use wordpress/scripts package for ESLint
kienstra Dec 18, 2019
0bb5545
Remove UglifyJSPlugin from webpack.config.js
kienstra Dec 19, 2019
88c792d
Add a rule to .eslintrc of no-unused-vars
kienstra Dec 19, 2019
8c2eee5
Don't require trailing commas for function calls
kienstra Dec 19, 2019
ccdc727
Always require a trailing comma on multiline import and export statem…
kienstra Dec 19, 2019
fc86cb9
Remove require() statement for 'uglifyjs-webpack-plugin'
kienstra Dec 19, 2019
3ced431
Add wp-scripts lint-pkg-json script, correct package.json
kienstra Dec 19, 2019
1813c71
Add wp-scripts check-licenses to package.json
kienstra Dec 19, 2019
9fdcf9f
Import the WordPress dependencies as modules, use dependency plugin
kienstra Jan 11, 2020
2fd6706
Remove a duplicate 'WordPress dependencies' DocBlock
kienstra Jan 11, 2020
edd1bfd
Address console warnings for deprecations
kienstra Jan 12, 2020
440f50a
Remove the <DotTip>, as its package is deprecated
kienstra Jan 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
},
"rules": {
"@wordpress/dependency-group": "error",
"@wordpress/react-no-unsafe-timeout": "error"
"@wordpress/react-no-unsafe-timeout": "error",
"no-unused-vars": [
"error",
{
"ignoreRestSiblings": true
}
]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file could probably use more rules, but that's not in scope for this PR.

}
}
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ tmp/
#######
.npmignore
node_modules
package-lock.json

# Always-ignore extensions #
########################
Expand All @@ -88,6 +87,7 @@ package-lock.json
*.swp
*.tmp
*.bak
*.map
Copy link
Collaborator Author

@kienstra kienstra Dec 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new build process creates .map files, like block-lab/css/blocks.editor.css.map.


# Sass #
#######
Expand Down
4 changes: 3 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ gulp.task( 'clean:bundle', function () {
'package/trunk/coverage',
'package/trunk/js/blocks',
'package/trunk/js/src',
'package/trunk/js/*.map',
'package/trunk/css/*.map',
'package/trunk/bin',
'package/trunk/node_modules',
'package/trunk/vendor',
Expand All @@ -103,4 +105,4 @@ gulp.task( 'default', gulp.series(
'wporg:trunk',
'version',
'clean:bundle'
) );
) );
2 changes: 1 addition & 1 deletion js/admin.block-post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@
const postType = $( input ).val();
if ( -1 === excludedPostTypes.indexOf( postType ) ) {
displayList.push(
$( input ).next( 'label' ).text()
$( input ).next( 'label' ).text(),
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion js/blocks/components/advanced-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const AdvancedControls = ( { block } ) => {

const tip = sprintf(
__( 'The Additional CSS Class can be included in your block template with the %1$s field.', 'block-lab' ),
'<code>className</code>'
'<code>className</code>',
);

return (
Expand Down
2 changes: 1 addition & 1 deletion js/blocks/components/fetch-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class FetchInput extends Component {
'%d result found, use up and down arrow keys to navigate.',
'%d results found, use up and down arrow keys to navigate.',
results.length,
'block-lab'
'block-lab',
), results.length ), 'assertive' );

if ( null === this.state.selectedSuggestion && '' !== this.getInputValue() ) {
Expand Down
2 changes: 1 addition & 1 deletion js/blocks/components/repeater-rows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class RepeaterRows extends Component {
setTimeout( () => { /* eslint-disable-line @wordpress/react-no-unsafe-timeout */
rowRefTo.classList.remove( 'row-to' );
rowRefFrom.classList.remove( 'row-from' );
}, 1000 )
}, 1000 ),
);

scrollContainer.scroll( { top: scrollTop, behavior: 'smooth' } );
Expand Down
2 changes: 1 addition & 1 deletion js/blocks/loader/fields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const simplifiedFields = ( fields ) => {
{
...field,
name: fieldName,
}
},
);
}

Expand Down
Loading