-
Notifications
You must be signed in to change notification settings - Fork 64
Update versions in package.json, use @wordpress/scripts for build process #492
Changes from all commits
0c57b81
7b643f4
e6cbebe
057e2b3
66e1649
4005f48
0bb5545
88c792d
8c2eee5
ccdc727
fc86cb9
3ced431
1813c71
9fdcf9f
2fd6706
edd1bfd
440f50a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,22 @@ | |
}, | ||
"rules": { | ||
"@wordpress/dependency-group": "error", | ||
"@wordpress/react-no-unsafe-timeout": "error" | ||
"@wordpress/react-no-unsafe-timeout": "error", | ||
"comma-dangle": [ | ||
"error", | ||
{ | ||
"arrays": "always-multiline", | ||
"objects": "always-multiline", | ||
"imports": "always-multiline", | ||
"exports": "always-multiline", | ||
"functions": "never" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A trailing comma after the last argument looks strange to me: ...and it doesn't have great browser support. This Ideally, soon that file will be ported to the React logic in the refactoring. |
||
} | ||
], | ||
"no-unused-vars": [ | ||
"error", | ||
{ | ||
"ignoreRestSiblings": true | ||
} | ||
] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file could probably use more rules, but that's not in scope for this PR. |
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,7 +74,6 @@ tmp/ | |
####### | ||
.npmignore | ||
node_modules | ||
package-lock.json | ||
|
||
# Always-ignore extensions # | ||
######################## | ||
|
@@ -88,6 +87,7 @@ package-lock.json | |
*.swp | ||
*.tmp | ||
*.bak | ||
*.map | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new build process creates |
||
|
||
# Sass # | ||
####### | ||
|
@@ -117,3 +117,4 @@ js/editor.blocks.js | |
js/scripts.js | ||
css/blocks.editor.css | ||
package/ | ||
*.asset.php |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
const { applyFilters } = wp.hooks; | ||
const { select } = wp.data; | ||
import { applyFilters } from '@wordpress/hooks'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reason for importing these as modules instead of using something like For example, If we control the versions of the modules, we should be less dependent on the version of Core and Gutenberg users have. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A user reported an error from |
||
import { select } from '@wordpress/data'; | ||
|
||
/** | ||
* Internal dependencies | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires the trailing comma after 'bar' here:
...but doesn't allow a trailing comma after 'bar' here: