-
Notifications
You must be signed in to change notification settings - Fork 112
Respect GZ_PYTHON_INSTALL_PATH if passed as an argument #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
macos workflow failure is unrelated: #1587 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good; we probably want to do this for gz-math and other packages as well
Similar to gazebosim/sdformat#1586. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@j-rivero do we still want this change even though we didn't use it for the vendor packages? |
I think that could be useful for other packagers yes, let's get it now that we did all the work. Thanks guys. |
Similar to gazebosim/sdformat#1586. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Similar to gazebosim/sdformat#1586. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Similar to gazebosim/sdformat#1586. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Similar to gazebosim/sdformat#1586. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
🦟 Bug fix
Summary
The PR adds the ability to set the
GZ_PYTHON_INSTALL_PATH
from CMake arguments by no overriding it if it is set. This is useful for paths injected by the different package managers and distributions.One use case is for the ROS vendor packages where the Python path is controlled by an
ament_python
helper call.Easier to see https://github.com/gazebosim/sdformat/pull/1586/files?w=1
Checklist
codecheck
passed (See contributing)GeNote to maintainers**: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.