Skip to content

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 5, 2025

🦟 Bug fix

Summary

The PR adds the ability to set the GZ_PYTHON_INSTALL_PATH from CMake arguments by no overriding it if it is set. This is useful for paths injected by the different package managers and distributions.

One use case is for the ROS vendor packages where the Python path is controlled by an ament_python helper call.

Easier to see https://github.com/gazebosim/sdformat/pull/1586/files?w=1

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

GeNote to maintainers**: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
@scpeters
Copy link
Member

scpeters commented Sep 5, 2025

macos workflow failure is unrelated: #1587

@scpeters
Copy link
Member

scpeters commented Sep 5, 2025

macos workflow failure is unrelated: #1587

workaround in #1588

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; we probably want to do this for gz-math and other packages as well

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 5, 2025
scpeters added a commit to gazebosim/gz-math that referenced this pull request Sep 8, 2025
Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member

@j-rivero do we still want this change even though we didn't use it for the vendor packages?

@j-rivero
Copy link
Contributor Author

@j-rivero do we still want this change even though we didn't use it for the vendor packages?

I think that could be useful for other packagers yes, let's get it now that we did all the work. Thanks guys.

@j-rivero j-rivero merged commit ae7ac38 into sdf16 Sep 30, 2025
15 checks passed
@j-rivero j-rivero deleted the jrivero/respect_python_install_path branch September 30, 2025 09:57
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 30, 2025
scpeters added a commit to gazebosim/gz-math that referenced this pull request Oct 3, 2025
Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-math that referenced this pull request Oct 8, 2025
Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-math that referenced this pull request Oct 8, 2025
Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-math that referenced this pull request Oct 8, 2025
Similar to gazebosim/sdformat#1586.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants