Enable Python Bindings support #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
remember to propagate to https://github.com/gazebo-tooling/gz_vendor once we are happy with how this works |
|
alternative approach in #18, based on gazebo-tooling/gz_vendor#23 |
|
Not a good idea since the files go outside of the scope of the subidrectory where ROS vendor packages are installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR enables the build of the Python Bindings for the package. Part of gazebo-tooling/gz_vendor#2 (comment)
Use the
ament_cmake_pythonpackage to get the Python install path used by ROS and inject that directly to the CMake arguments passed in the vendor package.In draft until gazebosim/sdformat#1586 is merged, which is a pre-requisite.