Skip to content

Fix crash when adding a Light via Component Inspector Editor #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix crash when adding a Light via Component Inspector Editor #3137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d091c55
Fix crash by adding nullptr check
XINJIANGMO Oct 19, 2025
5a48e92
Update src/rendering/RenderUtil.cc
ahcorde Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/rendering/RenderUtil.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3797,6 +3797,14 @@ void RenderUtilPrivate::CreateVisual(
sdf::Visual visual;
visual.SetName(_name->Data());
visual.SetRawPose(_pose->Data());
if(!_geom)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this check can be moved to the start of the function, i.e. before sdf::Visual visual

{
gzwarn << "Visual entity [" << _entity
<< "] has no geometry component."
<< "Skipping visual creation."
<< std::endl;
return;
}
visual.SetGeom(_geom->Data());
visual.SetCastShadows(_castShadows->Data());
visual.SetTransparency(_transparency->Data());
Expand Down
Loading