Fix crash when adding a Light
via Component Inspector Editor
#3137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3131
Summary
When adding a
light
viaComponent Inspector Editor
, the created entity ends up with aVisual
component but no validGeometry
.RenderUtil::CreateVisual
assumesGeometry
is present and callsvisual.SetGeom(_geom->Data())
, causing a crash.This fix
return
early when_geom
isnullptr
, avoiding thecrash
inSetGeom
, while not affectinglight
creationChecklist
codecheck
passed (See contributing)