Expose APIs for clearing the ECMs internal state tracking addition and removal (backport #3002) #3126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This is necessary for use with the
SetState
API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM.Currently, we use
friend
relationships for theGuiRunner
class to allow it to run these functions, but this is not feasible for external code that wants to useSetState
.gz-sim/include/gz/sim/EntityComponentManager.hh
Lines 833 to 838 in 5ce62a8
gz-sim/src/gui/GuiRunner.cc
Lines 316 to 318 in 5ce62a8
This is needed for gazebosim/ros_gz#790 to be able to get the updated state of the world, for example, when requested for the list of entities in the world after an entity has been removed.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.This is an automatic backport of pull request #3002 done by Mergify.