-
Notifications
You must be signed in to change notification settings - Fork 342
Expose APIs for clearing the ECMs internal state tracking addition and removal #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d removal This is necessary for use with the `SetState` API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM. Currently, we use `friend` relationships for the `GuiRunner` class to allow it to run these functions, but this is not feasible for external code that wants to use `SetState`. https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/include/gz/sim/EntityComponentManager.hh#L834, https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/src/gui/GuiRunner.cc#L316-L318 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
iche033
approved these changes
Jul 25, 2025
10 tasks
azeey
added a commit
to azeey/gz-sim
that referenced
this pull request
Aug 18, 2025
…d removal (gazebosim#3002) This is necessary for use with the `SetState` API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM. Currently, we use `friend` relationships for the `GuiRunner` class to allow it to run these functions, but this is not feasible for external code that wants to use `SetState`. https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/include/gz/sim/EntityComponentManager.hh#L834, https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/src/gui/GuiRunner.cc#L316-L318 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@Mergifyio backport gz-sim9 gz-sim8 Backporting to Ionic and Harmonic to get gazebosim/ros_gz#790 backported all the way to Jazzy. See gazebosim/ros_gz#732 (comment) |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…d removal (#3002) This is necessary for use with the `SetState` API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM. Currently, we use `friend` relationships for the `GuiRunner` class to allow it to run these functions, but this is not feasible for external code that wants to use `SetState`. https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/include/gz/sim/EntityComponentManager.hh#L834, https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/src/gui/GuiRunner.cc#L316-L318 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit b2f3c82)
10 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…d removal (#3002) This is necessary for use with the `SetState` API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM. Currently, we use `friend` relationships for the `GuiRunner` class to allow it to run these functions, but this is not feasible for external code that wants to use `SetState`. https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/include/gz/sim/EntityComponentManager.hh#L834, https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/src/gui/GuiRunner.cc#L316-L318 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit b2f3c82)
10 tasks
azeey
added a commit
that referenced
this pull request
Oct 16, 2025
…d removal (#3002) This is necessary for use with the `SetState` API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM. Currently, we use `friend` relationships for the `GuiRunner` class to allow it to run these functions, but this is not feasible for external code that wants to use `SetState`. https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/include/gz/sim/EntityComponentManager.hh#L834, https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/src/gui/GuiRunner.cc#L316-L318 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit b2f3c82)
azeey
added a commit
that referenced
this pull request
Oct 16, 2025
…d removal (#3002) This is necessary for use with the `SetState` API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM. Currently, we use `friend` relationships for the `GuiRunner` class to allow it to run these functions, but this is not feasible for external code that wants to use `SetState`. https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/include/gz/sim/EntityComponentManager.hh#L834, https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/src/gui/GuiRunner.cc#L316-L318 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit b2f3c82)
azeey
added a commit
that referenced
this pull request
Oct 17, 2025
…d removal (#3002) This is necessary for use with the `SetState` API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM. Currently, we use `friend` relationships for the `GuiRunner` class to allow it to run these functions, but this is not feasible for external code that wants to use `SetState`. https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/include/gz/sim/EntityComponentManager.hh#L834, https://github.com/gazebosim/gz-sim/blob/5ce62a8826b930078fae940288ac9677aae9ec7b/src/gui/GuiRunner.cc#L316-L318 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit b2f3c82)
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This is necessary for use with the
SetState
API. This API is commonly used to create a local version of the servers ECM that is periodically synchronized. However, without exposing this function into our public API additions and removals of entities or components are not reflected in the local ECM.Currently, we use
friend
relationships for theGuiRunner
class to allow it to run these functions, but this is not feasible for external code that wants to useSetState
.gz-sim/include/gz/sim/EntityComponentManager.hh
Lines 833 to 838 in 5ce62a8
gz-sim/src/gui/GuiRunner.cc
Lines 316 to 318 in 5ce62a8
This is needed for gazebosim/ros_gz#790 to be able to get the updated state of the world, for example, when requested for the list of entities in the world after an entity has been removed.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.