Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 15, 2025

🦟 Bug fix

Fixes #3109

Summary

Currently with the FileDialog.OpenFile file mode, users can only save the world sdf to an existing file. This PR changes the file mode to FileDilaog.SaveFile so that users can create a new file to save.

This textfield for naming a new file should now be available in the file dialog. On ubuntu, this will appear at the top of the dialog:

Screenshot 2025-10-14 at 9 59 20 AM

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #3110 done by [Mergify](https://mergify.com).

Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 097c9a5)
@mergify mergify bot requested a review from arjo129 as a code owner October 15, 2025 01:09
@mergify mergify bot mentioned this pull request Oct 15, 2025
9 tasks
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Oct 15, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 15, 2025
@ahcorde ahcorde enabled auto-merge (squash) October 15, 2025 08:00
@iche033 iche033 disabled auto-merge October 15, 2025 21:15
@iche033 iche033 merged commit 4dab9e0 into gz-sim10 Oct 15, 2025
14 of 15 checks passed
@iche033 iche033 deleted the mergify/bp/gz-sim10/pr-3110 branch October 15, 2025 21:15
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Save Word and Save world as can not work after Qt6 Migration

2 participants