Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 14, 2025

🦟 Bug fix

Fixes #3109

Summary

Currently with the FileDialog.OpenFile file mode, users can only save the world sdf to an existing file. This PR changes the file mode to FileDilaog.SaveFile so that users can create a new file to save.

This textfield for naming a new file should now be available in the file dialog. On ubuntu, this will appear at the top of the dialog:

Screenshot 2025-10-14 at 9 59 20 AM

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 14, 2025
@iche033 iche033 merged commit 097c9a5 into main Oct 15, 2025
13 of 14 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 15, 2025
@iche033 iche033 deleted the iche033/save_world_filedialog branch October 15, 2025 01:08
@iche033
Copy link
Contributor Author

iche033 commented Oct 15, 2025

@Mergifyio backport gz-sim10

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2025

backport gz-sim10

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 097c9a5)
iche033 added a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 097c9a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants