Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 5, 2025

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#1640

Alternative to: #2590

Summary

Loading the logging playback plugin before SceneBroadcaster prevents playback from being displayed on the GUI. This order was changed in #2452 which caused the regression.

I haven't had time to delve into why the order matters, but it can easily be verified by running test/worlds/log_playback.sdf with <playback_path> set to the log directory. If the plugin comes before SceneBroadcaster, the playback is not displayed on the GUI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #2611 done by [Mergify](https://mergify.com).

Loading the logging playback plugin before `SceneBroadcaster`
prevents playback from being displayed on the GUI.

---------

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai>
(cherry picked from commit ca40c1d)

# Conflicts:
#	src/SimulationRunner.cc
@mergify mergify bot added the conflicts label Aug 5, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Aug 5, 2025

Cherry-pick of ca40c1d has failed:

On branch mergify/bp/gz-sim8/pr-2611
Your branch is up to date with 'origin/gz-sim8'.

You are currently cherry-picking commit ca40c1db.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/SimulationRunner.cc

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from mjcarroll as a code owner August 5, 2025 03:33
@mergify mergify bot mentioned this pull request Aug 5, 2025
8 tasks
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 5, 2025
arjo129 added 2 commits August 5, 2025 07:56
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@arjo129 arjo129 linked an issue Aug 5, 2025 that may be closed by this pull request
18 tasks
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Aug 5, 2025
@arjo129 arjo129 removed the conflicts label Aug 5, 2025
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@azeey azeey merged commit 98b6037 into gz-sim8 Aug 6, 2025
9 checks passed
@azeey azeey deleted the mergify/bp/gz-sim8/pr-2611 branch August 6, 2025 15:54
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Gazebo Sim GUI stays blank during playback tutorial

2 participants