Skip to content

Remove all references to runGui_main and reuse new binaries for RL tutorial. #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2025
Merged

Remove all references to runGui_main and reuse new binaries for RL tutorial. #2947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79c7f4f
Update RL example to use new GUI binary
arjo129 Jun 13, 2025
23dea5b
Fix path names
arjo129 Jun 13, 2025
12ac43a
Missed one target
arjo129 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/scripts/reinforcement_learning/simple_cart_pole/cart_pole_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ def run_gui():
an instance of the gui client
"""
if os.name == 'nt':
base = os.path.join(get_install_prefix(), "libexec", "runGui.exe")
base = os.path.join(get_install_prefix(), "libexec", "gz", "sim10","gz-sim-gui-client.exe")
else:
base = os.path.join(get_install_prefix(), "libexec", "runGui")
base = os.path.join(get_install_prefix(), "libexec", "gz", "sim10", "gz-sim-gui-client")
subprocess.Popen(base)

class GzRewardScorer:
Expand Down
8 changes: 0 additions & 8 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,6 @@ if (MSVC)
set_source_files_properties(${sources} ${gtest_sources} COMPILE_FLAGS "/wd4251 /wd4146")
endif()


# Executable target that runs the GUI without ruby for debugging purposes.
if(ENABLE_GUI)
add_executable(runGui cmd/runGui_main.cc)
target_link_libraries(runGui PRIVATE ${gz_lib_target} gz-gui gz)
install(TARGETS runGui DESTINATION ${CMAKE_INSTALL_PREFIX}/libexec)
endif()

# Create the library target
gz_create_core_library(SOURCES ${sources} CXX_STANDARD 17)
gz_add_get_install_prefix_impl(GET_INSTALL_PREFIX_FUNCTION gz::sim::getInstallPrefix
Expand Down
23 changes: 0 additions & 23 deletions src/cmd/runGui_main.cc
View file
Open in desktop

This file was deleted.