Skip to content

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Jun 13, 2025

🦟 Bug fix

Fixes #

Summary

Remove all references to runGui_main and reuse new binaries for RL tutorial.

The RL tutorial relies on runGui_main, however since @sauk2 and @j-rivero to use binaries instead of dynamically loading libraries, this tutorial needs an update. Additionally, since we are not building runGui_main, I've removed it to prevent future confusion. One thing I don;t like about this method is the use of version numbers in our script. I will look at how best to address this by directly adding a python API for the visuallizer.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Remove all references to `runGui_main` and reuse new binaries for RL
tutorial.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@arjo129 arjo129 requested a review from mjcarroll as a code owner June 13, 2025 06:23
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Jun 13, 2025
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jun 13, 2025
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@arjo129 arjo129 merged commit 2e1679e into main Jun 14, 2025
9 checks passed
@arjo129 arjo129 deleted the arjo/fix/remove_run_main branch June 14, 2025 08:24
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants