Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 19, 2025

🦟 Bug fix

Fixes #2903

Summary

This PR fixes issue #2903 and prevents the server from segfaulting if the plugin fails to load correctly. It prints an error that the plugin was misconfigured and continues executing ahead.

At some point we should revisit our plugin loading interface. A lot of work is placed in the developers hands to understand internals of gazebo's lifecycle. For starters, we should try to call Configure after the entities are created. It'd also be nice to be able to return an error during Configure and just not care about executing the plugin in the future. I'll open a ticket outlining how we can go about doing this with minimal interruptions to out currently existing codebase.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸


This is an automatic backport of pull request #2907 done by [Mergify](https://mergify.com).

This PR fixes issue #2903 and prevents the server from segfaulting if
the plugin fails to load correctly. It prints an error that the plugin
was misconfigured and continues executing ahead.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
(cherry picked from commit 049c19e)

# Conflicts:
#	src/systems/lift_drag/LiftDrag.cc
@mergify mergify bot added the conflicts label May 19, 2025
@mergify mergify bot requested a review from mjcarroll as a code owner May 19, 2025 04:15
@mergify
Copy link
Contributor Author

mergify bot commented May 19, 2025

Cherry-pick of 049c19e has failed:

On branch mergify/bp/ign-gazebo6/pr-2907
Your branch is up to date with 'origin/ign-gazebo6'.

You are currently cherry-picking commit 049c19e9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/systems/lift_drag/LiftDrag.cc

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label May 19, 2025
@mergify mergify bot mentioned this pull request May 19, 2025
8 tasks
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 19, 2025
@arjo129 arjo129 closed this May 19, 2025
@github-project-automation github-project-automation bot moved this from Inbox to Done in Core development May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant