Fixes issue #2903 #2907
Merged
Fixes issue #2903 #2907
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes issue #2903 and prevents the server from segfaulting if the plugin fails to load correctly. It prints an error that the plugin was misconfigured and continues executing ahead. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
ahcorde
approved these changes
May 16, 2025
|
@Mergifyio backport gz-sim8 gz-sim9 ign-gz6 |
❌ No backport have been created
GitHub error: |
8 tasks
8 tasks
|
https://github.com/Mergifyio backport ign-gazebo6 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2025
This PR fixes issue #2903 and prevents the server from segfaulting if the plugin fails to load correctly. It prints an error that the plugin was misconfigured and continues executing ahead. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> (cherry picked from commit 049c19e) # Conflicts: # src/systems/lift_drag/LiftDrag.cc
8 tasks
arjo129
added a commit
that referenced
this pull request
May 19, 2025
This PR fixes issue #2903 and prevents the server from segfaulting if the plugin fails to load correctly. It prints an error that the plugin was misconfigured and continues executing ahead. (cherry picked from commit 049c19e) Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai>
arjo129
added a commit
that referenced
this pull request
May 19, 2025
This PR fixes issue #2903 and prevents the server from segfaulting if the plugin fails to load correctly. It prints an error that the plugin was misconfigured and continues executing ahead. (cherry picked from commit 049c19e) Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai>
arjo129
added a commit
that referenced
this pull request
May 26, 2025
8 tasks
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2903
Summary
This PR fixes issue #2903 and prevents the server from segfaulting if the plugin fails to load correctly. It prints an error that the plugin was misconfigured and continues executing ahead.
At some point we should revisit our plugin loading interface. A lot of work is placed in the developers hands to understand internals of gazebo's lifecycle. For starters, we should try to call Configure after the entities are created. It'd also be nice to be able to return an error during Configure and just not care about executing the plugin in the future. I'll open a ticket outlining how we can go about doing this with minimal interruptions to out currently existing codebase.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸