-
Notifications
You must be signed in to change notification settings - Fork 342
Bump gz-cmake and others in jetty #2910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumping gz-cmake and others except gz-tools. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* image_format -> pixel_format * gps -> navsat Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This reverts commit 91cf5b8. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
I noticed some gz-msgs deprecation warnings and tried to naively fix them in 91cf5b8, but that didn't work, so I've reverted it for now |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
I've properly fixed the pixel_format warnings in ede686b, but I believe there was a typo in gazebosim/gz-msgs#476, so I opened gazebosim/gz-msgs#515 to fix it. |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
I think the deprecation warnings and python tests are now fixed. I expect the homebrew CI to pass when it finished, but the
|
I've seen these kind of messages lately in my Gazebo runs but I think that they are not critical. Looking deeper:
Seems to a me a message coming from new standalone execs complaining about a lack of a |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Oh I see that the output of the command is critical for the test. Following up on the Lowest level minimal reproducible example I found by now is a simple run of /usr/libexec/gz/msgs12/gz-msgs. Only happens to me with the .deb gz-msgs12 nightlies. Can not reproduce it with the same code version than the nightlies in a colcon workspace. Can not find any big difference between the colcon log and the debbuilder log aside of compiler flags that being injected manually did not change the result. Something related to the nightly libgz-msgs.so.12 is making the error to appear. |
Ok, I get it. It has to do with the installation at the same time of the nightlies libgz-msgs11-dev and libgz-msgs12-dev. They are probably shipping the same files (since we created 12 during the transition) and something put both set of files in the protobuf knowledge by some-mechanism-vooodo. We just need to check what is still pulling the msgs11 packages into our builds and solve that. |
yeah I see that lots of Ionic packages are still being installed by our nightlies somehow
|
putting the incorrect dependency versions aside, there is a repeatable test failure in the GitHub workflow:
the error message is strange because the command executed is |
ok, wow I just rebuilt gz-utils with |
one short-term option is to revert gazebosim/gz-utils#167 |
another option is to modify the debian build rules to configure with for testing purposes, I have built a new nightly with that branch and retriggered Ubuntu CI jobs |
This fixed the Ubuntu workflows, though the Jenkins job is failing; I suspect that is due to a docker cache issue |
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
I've committed a workaround for the problem of CLI11 in af0f309. I think that would be better than moving other pieces in releasing. Detailed the problem in #2918 |
Running a build using gazebo-tooling/release-tools#1319 in |
The failures related to the gz model are gone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one short-term option is to revert gazebosim/gz-utils#167
I've committed a workaround for the problem of CLI11 in af0f309. I think that would be better than moving other pieces in releasing.
Detailed the problem in #2918
I commented on #2918. Since gz-sim-model
has been working with the vendored 1.9.1 and works with 2.5.0, this seems more like a problem with 2.4.2 to me. As I said above, I prefer restoring vendoring in gz-utils as a short-term workaround until we can merge this PR, then open a separate PR to modify gz-sim-model
with af0f309. Otherwise that change to gz-sim-model
will be buried in this large pull request
This reverts commit af0f309.
|
vendoring has been restored, now building a new gz-utils4 nightly deb |
@osrf-jenkins run tests please |
gazebo-tooling/release-tools#1319 is merged, but it didn't seem to fix the Ubuntu jenkins build https://build.osrfoundation.org/job/gz_sim-ci-pr_any-noble-amd64/765/ |
there seems to be just one CI machine that is failing, so I've restarted the build on a different machine that I think will pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
building new nightly deb: |
Log is:
I tried to optimize running the apt-get upgrade command by running first the autoremove but it does seem to find packages to remove until apt-get upgrade is executed. Need to invert the commands gazebo-tooling/release-tools#1320 |
Part of gazebo-tooling/release-tools#1309.