-
Notifications
You must be signed in to change notification settings - Fork 51
Remove symlink loops in engine-plugins #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no more versioned libraries, so these symlinks were creating a loop, just remove them. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
this fixes the tests
|
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
83 tasks
iche033
approved these changes
May 19, 2025
building nightly |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gz-sim test failures with PR chain in gazebosim/gz-sim#2910, part of gazebo-tooling/release-tools#1309
Summary
When testing the remaining Jetty version bumps (such as gazebosim/gz-sim#2910), I ran a colcon build:
and noticed two gz-sim test failures in particular the seem related to symlinked physics plugins:
In both cases:
Since there are no more versioned libraries, we should just remove these symlinks.
I will start a colcon build including this branch after confirming it doesn't break this package's CI.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.