Skip to content

Disable standalone_gtest_setup example test on mac #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Add missing virtual destructors
merged 1 commit into from
May 12, 2025
Merged

Disable standalone_gtest_setup example test on mac #2892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion examples/standalone/gtest_setup/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ foreach(TEST_TARGET
gtest_main
gz-sim::gz-sim
)

include(GoogleTest)
gtest_discover_tests(${TEST_TARGET})
if (APPLE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this issue will occur on other platforms with cmake 4? If so, I would check the cmake version instead of APPLE

I'm not sure though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some tests:

  • Ubuntu + cmake 4.0.1: built fine
  • Mac + cmake 3.31.7: same error
  • Mac + cmake 3.31.6: same error

hmm maybe something else has changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird

I've tried disabling ccache and that seems to fix it for me?

testing without ccache using gazebo-tooling/release-tools@b7cd4e3:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that didn't help

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I can't reproduce the failure on my personal machine at all, though it still fails in CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I can still reproduce it. I don't have ccache setup.

gtest_discover_tests(${TEST_TARGET} DISCOVERY_MODE PRE_TEST)
else()
gtest_discover_tests(${TEST_TARGET})
endif()
endforeach()
Loading