Disable standalone_gtest_setup example test on mac #2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
scpeters
reviewed
Apr 29, 2025
|
|
||
| include(GoogleTest) | ||
| gtest_discover_tests(${TEST_TARGET}) | ||
| if (APPLE) |
There was a problem hiding this comment.
Do you think this issue will occur on other platforms with cmake 4? If so, I would check the cmake version instead of APPLE
I'm not sure though
There was a problem hiding this comment.
I did some tests:
- Ubuntu + cmake 4.0.1: built fine
- Mac + cmake 3.31.7: same error
- Mac + cmake 3.31.6: same error
hmm maybe something else has changed
There was a problem hiding this comment.
weird
I've tried disabling ccache and that seems to fix it for me?
testing without ccache using gazebo-tooling/release-tools@b7cd4e3:
There was a problem hiding this comment.
now I can't reproduce the failure on my personal machine at all, though it still fails in CI
There was a problem hiding this comment.
hmm I can still reproduce it. I don't have ccache setup.
scpeters
changed the title
scpeters
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2889
Summary
The test was also failing locally on my mac but with a slightly different error msg from the output in #2889:
Setting
DISCOVERY_MODEtoPRE_TESTingtest_discover_testsmakes gtest delay test discovery until before test execution. By default it's done at build time withPOST_BUILD.From cmake doc on
PRE_TEST:I was able to build and run the test locally with these changes.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.