Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2025

🎉 New feature

Closes #

Summary

Not sure if we have tutorial for environment sensors but it took me some time to understand how to use the GUI plugins associated with the environment gz-sim systems. We should probably add a tutorial for this. In the mean time, I added some doc to the example world file.

I also moved the EnvironmentalSystem system below the EnvironmentPreload otherwise it prints out a confusing error message:

error] [EnvironmentalSensorSystem.cc:460] No sensor data loaded

This message is actually harmless because it will retry on PostUpdate and succeeds once EnvironmentPreload system is loaded. I rearranged the order of the systems so that the data is ready before loading the EnvironmentalSystem system

Test it

Follow the instructions in the updated environmental_sensor.sdf world and you should point cloud visualization in the 3D scene:

environment_visualization

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #2836 done by [Mergify](https://mergify.com).

Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 2aaa0ed)
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Mar 31, 2025
@ahcorde ahcorde enabled auto-merge (squash) March 31, 2025 08:17
@ahcorde
Copy link
Contributor

ahcorde commented Apr 1, 2025

@iche033 can you merge this one ?

@iche033 iche033 disabled auto-merge April 1, 2025 23:25
@iche033 iche033 merged commit b23c089 into gz-sim8 Apr 1, 2025
10 of 11 checks passed
@iche033 iche033 deleted the mergify/bp/gz-sim8/pr-2836 branch April 1, 2025 23:25
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants