Add more documentation to environmental_sensor.sdf example world #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
ahcorde
approved these changes
Mar 28, 2025
|
@Mergifyio backport gz-sim9 gz-sim8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 2aaa0ed)
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 2aaa0ed)
This was referenced Mar 28, 2025
|
Lol, I wrote one ages ago: #1806 Maybe I'll go in and finish that up. |
oh nice! I missed that. Yeah would be good to get that in, but no hurry. |
iche033
added a commit
that referenced
this pull request
Apr 1, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 2aaa0ed)
iche033
added a commit
that referenced
this pull request
Apr 1, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 2aaa0ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #
Summary
Not sure if we have tutorial for environment sensors but it took me some time to understand how to use the GUI plugins associated with the environment gz-sim systems. We should probably add a tutorial for this. In the mean time, I added some doc to the example world file.
I also moved the
EnvironmentalSystemsystem below theEnvironmentPreloadotherwise it prints out a confusing error message:This message is actually harmless because it will retry on
PostUpdateand succeeds onceEnvironmentPreloadsystem is loaded. I rearranged the order of the systems so that the data is ready before loading theEnvironmentalSystemsystemTest it
Follow the instructions in the updated environmental_sensor.sdf world and you should point cloud visualization in the 3D scene:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.