Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 16, 2024

🦟 Bug fix

Related: gazebosim/gazebo_test_cases#1264

Summary

Update links to point to gz-sim9 branch and fix one screenshot link

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (712643f) to head (944d7db).
Report is 9 commits behind head on gz-sim9.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim9    #2632      +/-   ##
===========================================
- Coverage    68.80%   68.76%   -0.04%     
===========================================
  Files          341      341              
  Lines        33037    33049      +12     
===========================================
- Hits         22730    22727       -3     
- Misses       10307    10322      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@ahcorde ahcorde enabled auto-merge (squash) September 17, 2024 11:12
@ahcorde ahcorde requested a review from azeey September 17, 2024 11:13
@azeey azeey disabled auto-merge September 17, 2024 17:52
@azeey azeey merged commit 76305df into gz-sim9 Sep 17, 2024
8 of 10 checks passed
@azeey azeey deleted the point_cloud_to_mesh_tut_update branch September 17, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants