Skip to content

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 16, 2024

🦟 Bug fix

Summary

ComponentDefault has been added quite some time ago. I've noticed the JointForceCmd component tutorial still uses the cumbersome if (component == null) CreateComponent() approach.

This PR modernizes it to use ComponentDefault and modernizes the accompanying tutorial as well.

I've compile- and run-tested this change and it seems everything works as it should.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Martin Pecka <peci1@seznam.cz>
@azeey azeey enabled auto-merge (squash) January 7, 2025 22:02
@azeey azeey merged commit d83d135 into gazebosim:gz-sim9 Jan 7, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants