Adds a regression test for logplayback fix in #2611 #2619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazebosim/gazebo_test_cases#1640 This commit adds a really simple regression check to make sure we actually publish on the right topic. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
|
https://github.com/Mergifyio backport gz-sim8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
* Adds a regression test for logplayback gazebosim/gazebo_test_cases#1640 This commit adds a really simple regression check to make sure we actually publish on the right topic. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * typo fix Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Make atomic Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 0f16949)
azeey
added a commit
that referenced
this pull request
Aug 13, 2025
* Adds a regression test for logplayback gazebosim/gazebo_test_cases#1640 This commit adds a really simple regression check to make sure we actually publish on the right topic. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * typo fix Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Make atomic Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 0f16949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
gazebosim/gazebo_test_cases#1640
This commit adds a really simple regression check to make sure we actually publish on the right topic.