Skip to content

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebo-tooling/release-tools#1244, companion to gazebosim/gz-gui#670.

Summary

The major version is removed from the cmake project name for gz-gui in gazebosim/gz-gui#670, so update the find_package and target_link_libraries calls accordingly.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Companion to gazebosim/gz-gui#670.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

scpeters commented Mar 31, 2025

@scpeters
Copy link
Member Author

scpeters commented Apr 1, 2025

testing this and dependent branches using gazebo-tooling/gazebodistro@e2988cb:

build did not fail, so this is ready for review

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 1, 2025
@scpeters scpeters merged commit 2365908 into main Apr 2, 2025
10 of 11 checks passed
@scpeters scpeters deleted the scpeters/package_name_without_major_version_gui branch April 2, 2025 07:06
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants