Skip to content

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Mar 31, 2025

🎉 New feature

Part of gazebo-tooling/release-tools#1244

Summary

This removes the major version from the package
name in the following places:

  • cmake project name and corresponding find_package calls in examples and tutorials
  • package.xml name

Test it

See companion pull requests for a colcon CI job testing all branches simultaneously

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This removes the major version from the package
name in the following places:

* cmake project name and corresponding find_package
  calls in examples and tutorials
* package.xml name

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from j-rivero March 31, 2025 21:08
@scpeters scpeters requested a review from jennuine as a code owner March 31, 2025 21:08
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Mar 31, 2025
scpeters added a commit to gazebosim/gz-sim that referenced this pull request Mar 31, 2025
Companion to gazebosim/gz-gui#670.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-launch that referenced this pull request Mar 31, 2025
Companion to gazebosim/gz-gui#670.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-jetty that referenced this pull request Mar 31, 2025
Companion to gazebosim/gz-gui#670.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 1, 2025
@scpeters scpeters merged commit 3da95a2 into main Apr 1, 2025
11 checks passed
@scpeters scpeters deleted the scpeters/package_name_without_major_version_gui branch April 1, 2025 17:28
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 1, 2025
@scpeters
Copy link
Member Author

scpeters commented Apr 1, 2025

trying a nightly build:

scpeters added a commit to gazebosim/gz-sim that referenced this pull request Apr 2, 2025
Companion to gazebosim/gz-gui#670.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-launch that referenced this pull request Apr 2, 2025
Companion to gazebosim/gz-gui#670.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-jetty that referenced this pull request Apr 2, 2025
Companion to gazebosim/gz-gui#670.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@j-rivero
Copy link
Contributor

j-rivero commented Apr 2, 2025

trying a nightly build:

great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants