-
Notifications
You must be signed in to change notification settings - Fork 59
Remove major version from package name #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the major version from the package name in the following places: * cmake project name and corresponding find_package calls in examples and tutorials * package.xml name Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebosim/gz-sim
that referenced
this pull request
Mar 31, 2025
Companion to gazebosim/gz-gui#670. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
9 tasks
scpeters
added a commit
to gazebosim/gz-launch
that referenced
this pull request
Mar 31, 2025
Companion to gazebosim/gz-gui#670. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebosim/gz-jetty
that referenced
this pull request
Mar 31, 2025
Companion to gazebosim/gz-gui#670. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Mar 31, 2025
j-rivero
approved these changes
Apr 1, 2025
trying a nightly build: |
scpeters
added a commit
to gazebosim/gz-sim
that referenced
this pull request
Apr 2, 2025
Companion to gazebosim/gz-gui#670. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebosim/gz-launch
that referenced
this pull request
Apr 2, 2025
Companion to gazebosim/gz-gui#670. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebosim/gz-jetty
that referenced
this pull request
Apr 2, 2025
Companion to gazebosim/gz-gui#670. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of gazebo-tooling/release-tools#1244
Summary
This removes the major version from the package
name in the following places:
find_package
calls in examples and tutorialsTest it
See companion pull requests for a colcon CI job testing all branches simultaneously
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.