-
Notifications
You must be signed in to change notification settings - Fork 10
Update pixi.toml to use qt6 6.8 #1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before we merge this, we need to consider that this is going to modify other releases using noble_like. We can generate the lock file and see the dependencies that are going to be affected. Being conservatives we can fork the fie although it will bring more maintenance effort if changes needs to be made across Gazebo releases (unlikely?). |
I am a proponent of having a pixi.toml file per release. It requires more changes in the infra, but once set up, we wouldn't need to update the toml files too often. And if we do, which would typically be at the beginning of a new release, we wouldn't have to worry about other releases. |
Reviewing the situation our Thinking more broadly, yes, we can probably maintain one file per Gazebo release, named them with the same name than the release so instead of using the directory name I drafted the changes #1393 |
Summary of changes done by
|
conda/envs/noble_like/pixi.toml
Outdated
QT_QPA_PLATFORM_PLUGIN_PATH="%cd%\\.pixi\\envs\\default\\Library\\lib\\qt6\\plugins\\platforms" | ||
QML2_IMPORT_PATH="%cd%\\.pixi\\envs\\default\\Library\\lib\\qt6\\qml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we use CONDA_PREFIX
here?
https://pixi.sh/dev/reference/environment_variables/#environment-variables-set-by-pixi
conda/envs/noble_like/pixi.toml
Outdated
platforms = ["linux-64", "linux-aarch64", "win-64"] | ||
|
||
[target.win-64.activation.env] | ||
QT_QPA_PLATFORM_PLUGIN_PATH="%cd%\\.pixi\\envs\\default\\Library\\lib\\qt6\\plugins\\platforms" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like this approach while we wait for an upstream fix.
Use CONDA_PREFIX instead of cd
Part of gazebosim/gz-sim#2945