-
Notifications
You must be signed in to change notification settings - Fork 130
[GEP-28] Report Machine.status.addresses
when running without target cluster
#1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @maboehm for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! I found only two typos in my review :)
Co-authored-by: Tim Ebert <timebertt@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@timebertt Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @maboehm!
Just a few comments from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
This looks good to me
/lgtm
What this PR does / why we need it:
Implements the suggestion from #1007 which is required for
gardenadm bootstrap
by introducing a new status fieldstatus.addresses
, which is only populated when the MCM runs without a target cluster (as usually theNode
status should be used).The
Driver
interface Response types are also extended to allow providers to return additional addresses. It is assumed that thenodeName
is always a valid address oftype=HostName
, so it is always added.Which issue(s) this PR fixes:
Fixes #1007
Special notes for your reviewer:
/cc @timebertt
I also created a draft PR in gardener gardener/gardener#12489, where the new fields are returned in the provider-local. This results in the following status on the machine object:
Release note:
When running without a target cluster machine-controller-manager will report a new status field `addresses`