Skip to content

Conversation

maboehm
Copy link
Contributor

@maboehm maboehm commented Jul 7, 2025

What this PR does / why we need it:
Implements the suggestion from #1007 which is required for gardenadm bootstrap by introducing a new status field status.addresses, which is only populated when the MCM runs without a target cluster (as usually the Node status should be used).

The Driver interface Response types are also extended to allow providers to return additional addresses. It is assumed that the nodeName is always a valid address of type=HostName, so it is always added.

Which issue(s) this PR fixes:
Fixes #1007

Special notes for your reviewer:
/cc @timebertt

I also created a draft PR in gardener gardener/gardener#12489, where the new fields are returned in the provider-local. This results in the following status on the machine object:

status:
  addresses:
  - address: machine-shoot--garden--root-control-plane-695dc-tr9jl
    type: Hostname
  - address: 10.1.130.204
    type: InternalIP

Release note:

When running without a target cluster machine-controller-manager will report a new status field `addresses`

@maboehm maboehm requested a review from a team as a code owner July 7, 2025 15:54
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jul 7, 2025
@gardener-robot-ci-1
Copy link
Contributor

Thank you @maboehm for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@aaronfern
Copy link
Member

aaronfern commented Jul 9, 2025

/ok-to-test
/assign

@gardener-robot gardener-robot added the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 9, 2025
@aaronfern aaronfern added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 9, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 9, 2025
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I found only two typos in my review :)

Co-authored-by: Tim Ebert <timebertt@gmail.com>
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot
Copy link

@timebertt Command /lgtm is not available to you but only to a Maintainer, Member.

Copy link
Member

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @maboehm!
Just a few comments from me

@maboehm maboehm requested a review from aaronfern July 30, 2025 14:11
Copy link
Member

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
This looks good to me
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 11, 2025
@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label Aug 11, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 11, 2025
@aaronfern aaronfern merged commit 942d124 into gardener:master Aug 14, 2025
14 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GEP-28] Report Machine.status.addresses when running without target cluster

6 participants