-
Notifications
You must be signed in to change notification settings - Fork 485
Update coreprofiler db #7341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update coreprofiler db #7341
Conversation
|
This PR close this one : #7331 |
|
Hi @SaimMomin12, I see that you rerun test, any idea why it fails ? The error doesn't seem to come from the tool. Is it a wrapper or a galaxy error ? |
No, unfortunately we are experiencing some CI issues lately. Nonetheless, we re-trigger the failed workflow manually :) |
|
I see the test timed out after 1800.25 seconds and failed. Let me loop in @bernt-matthias |
|
1800s is the max runtime of a test allowed in our CI. any way to speed things up? |
I'm not sure it's possible to speed things up. The three tests involve three different databases, and the last one, which concerns Enterobase, only has two possible values, and the one that was tested is the smallest. Maybe we can delete this one? The parameters used are the same as for the other databases. |
|
Currently, we have no way of speeding things up, so we can suggest removing this test, or perhaps it is possible to extend run time for CI ? |
bernt-matthias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm. Don't know how to continue. Maybe mock a test?
...rs/data_manager_build_coreprofiler/data_manager/data_manager_build_coreprofiler_download.xml
Outdated
Show resolved
Hide resolved
I remove the test that fail because of time limit, I use bash variables for token and secrets parameters (but I'm not sure I wrote or use them well), and I added a conditional to distinguish token and non token generated databases. |
FOR CONTRIBUTOR:
Closes: #7331