Skip to content

add cwd, env and envFile support #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,27 @@
"description": "The JVM arguments if needed by your project (usually -Dfoo=bar).",
"default": ""
},
"cwd": {
"type": "string",
"description": "The current working directory. Default to the project root.",
"default": "${workspaceFolder}"
},
"env": {
"type": "object",
"additionalProperties": {
"type": [
"string",
"null"
]
},
"description": "Environment variables in key/value format. (usually { \"FOO\": \"BAR\"})",
"default": {}
},
"envFile": {
"type": "string",
"description": "Environment variables file path. (usually .env)",
"default": "${workspaceFolder}/.env"
},
"enableJsonLogging": {
"type": "boolean",
"description": "Enables logging of debug server JSON messages into a file defined by 'jsonLogFile'.",
Expand Down
5 changes: 4 additions & 1 deletion src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ export async function activate(context: vscode.ExtensionContext): Promise<Extens
return;
}

const javaOpts = await findJavaOpts();
const initialJavaOpts = await findJavaOpts();
const addExportAppendix = "--add-exports jdk.jdi/com.sun.tools.jdi=ALL-UNNAMED"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this change do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in the description:

also injects --add-exports jdk.jdi/com.sun.tools.jdi=ALL-UNNAMED without which locally built debugAdapter refuses to start.

const javaOpts = initialJavaOpts === "" ? addExportAppendix : `${addExportAppendix} ${initialJavaOpts}`;

const setupParams: (status: Status) => ServerSetupParams = status => ({
context,
status,
Expand Down
Loading