add cwd, env and envFile support
#159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
reviewed
Apr 9, 2025
| @@ -58,7 +58,10 @@ export async function activate(context: vscode.ExtensionContext): Promise<Extens | |||
| return; | |||
| } | |||
|
|
|||
| const javaOpts = await findJavaOpts(); | |||
| const initialJavaOpts = await findJavaOpts(); | |||
| const addExportAppendix = "--add-exports jdk.jdi/com.sun.tools.jdi=ALL-UNNAMED" | |||
There was a problem hiding this comment.
it's in the description:
also injects --add-exports jdk.jdi/com.sun.tools.jdi=ALL-UNNAMED without which locally built debugAdapter refuses to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shameless copy of #42 (Huge thanks to @thunderz99 !) with the addition of
envFilesupport.also injects
--add-exports jdk.jdi/com.sun.tools.jdi=ALL-UNNAMEDwithout which locally build debugAdapter refuses to start.Supposed to be merged together with fwcd/kotlin-debug-adapter#90